fix(emit): Include class names that compose other classes #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export = cssExports; | ||
| " | ||
| `); | ||
| expect(declaration).toMatchSnapshot(); |
There was a problem hiding this comment.
Looks like the fix has broken this test.
There was a problem hiding this comment.
I just switched that one to a snapshot instead of an inline snapshot. I’m not sure why it was inline before vs. the external snapshot for the other case.
|
Anything I can do to improve this PR? 2.0.1 is broken compared to 2.0.0 without this patch. |
markdalgleish
approved these changes
May 7, 2019
|
Sadly this change breaks compatibility with tivac/modular-css 😿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2.0.1 breaks emitting definitions for classes that compose classes from another file. This is because the updated regex is looking for
/, butcss-loaderwill produce code that looks like this for composed classes:This adds a test for composed classes and fixes the bug. I had to upgrade Jest as well because the existing version could not run on my version of Node (11.11.0).